[all-commits] [llvm/llvm-project] 97aa01: [lldb] Call Target::ClearAllLoadedSections earlier...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 97aa01bef770ec651c86978d137933e09221dd00
      https://github.com/llvm/llvm-project/commit/97aa01bef770ec651c86978d137933e09221dd00
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2025-05-14 (Wed, 14 May 2025)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/lang/cpp/dynamic-value/TestDynamicValue.py

  Log Message:
  -----------
  [lldb] Call Target::ClearAllLoadedSections earlier (#138892)

Minidump files contain explicit information about load addresses of
modules, so it can load them itself. This works on other platforms, but
fails on darwin because DynamicLoaderDarwin nukes the loaded module list
on initialization (which happens after the core file plugin has done its
work).

This used to work until #109477, which enabled the dynamic loader
plugins for minidump files in order to get them to provide access to
TLS.

Clearing the load list makes sense, but I think we could do it earlier
in the process, so that both Process and DynamicLoader plugins get a
chance to load modules. This patch does that by calling the function
early in the launch/attach/load core flows.

This fixes TestDynamicValue.py:test_from_core_file on darwin.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications