[all-commits] [llvm/llvm-project] 1a0b82: [lldb-dap] Improving tests logging to understand C...

[John Harrison via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a0b82563fc720d5bf9ea22b940c08c51cb9e7b1
      https://github.com/llvm/llvm-project/commit/1a0b82563fc720d5bf9ea22b940c08c51cb9e7b1
  Author: John Harrison <harjohn at google.com>
  Date:   2025-05-13 (Tue, 13 May 2025)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
    M lldb/test/API/tools/lldb-dap/console/TestDAP_console.py
    M lldb/test/API/tools/lldb-dap/io/TestDAP_io.py

  Log Message:
  -----------
  [lldb-dap] Improving tests logging to understand CI failures. (#139311)

To improve logging this adjusts two properties of the existing tests:

* Forwards stderr from lldb-dap to the process in case errors are
reported to stderr.
* Adjusts `DebugAdapterServer.terminate` to close stdin and wait for the
process to exit instead of sending SIGTERM. Additionally, if we end up
with a non-zero exit status we now raise an error to note the unexpected
exit status.

With these changes, I did find one test case in
`TestDAP_console.test_diagnositcs` that was not waiting to ensure the
expected event had arrived by the time it performed an assert.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications