[all-commits] [llvm/llvm-project] f4b80b: LLVM symbolizer gsym support - attempt 2 (#139686)

[Mariusz Kwiczala via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f4b80b9109a65bd85f1f62d47cfc9f9395e1b5cc
      https://github.com/llvm/llvm-project/commit/f4b80b9109a65bd85f1f62d47cfc9f9395e1b5cc
  Author: Mariusz Kwiczala <70530507+sfc-gh-mkwiczala at users.noreply.github.com>
  Date:   2025-05-13 (Tue, 13 May 2025)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
    M llvm/include/llvm/DebugInfo/DIContext.h
    A llvm/include/llvm/DebugInfo/GSYM/GsymDIContext.h
    M llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
    M llvm/lib/DebugInfo/GSYM/CMakeLists.txt
    A llvm/lib/DebugInfo/GSYM/GsymDIContext.cpp
    M llvm/lib/DebugInfo/Symbolize/CMakeLists.txt
    M llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
    A llvm/test/tools/llvm-symbolizer/Inputs/addr-gsymonly.exe
    A llvm/test/tools/llvm-symbolizer/Inputs/addr-gsymonly.exe.gsym
    A llvm/test/tools/llvm-symbolizer/sym-gsymonly.test
    M llvm/tools/llvm-symbolizer/Opts.td
    M llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp
    M llvm/utils/gn/secondary/llvm/lib/DebugInfo/GSYM/BUILD.gn

  Log Message:
  -----------
  LLVM symbolizer gsym support - attempt 2 (#139686)

Add support for gsym files to llvm-symbolizer.

co-author @sfc-gh-sgiesecke

Notes:
There was a PR that was 
approved and merged: https://github.com/llvm/llvm-project/pull/134847 
and reverted: https://github.com/llvm/llvm-project/pull/139660
Due to buildbot failures:
https://lab.llvm.org/buildbot/#/builders/66/builds/13851 - it looks like
related
https://lab.llvm.org/buildbot/#/builders/51/builds/16018 - it looks like
related
https://lab.llvm.org/buildbot/#/builders/146/builds/2905 - it looks like
it's not related to changes

Fix:
To fix missing GSYM symbols 
```
+ diff -u expected.new undefined.new
+_ZN4llvm4gsym10GsymReader8openFileENS_9StringRefE U
+_ZN4llvm4gsym10GsymReaderC1EOS1_ U
+_ZN4llvm4gsym10GsymReaderD1Ev U
+_ZN4llvm4gsym13GsymDIContextC1ENSt20__InternalSymbolizer10unique_ptrINS0_10GsymReaderENS2_14default_deleteIS4_EEEE U
+ echo 'Failed: unexpected symbols'
```
for script
compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
LLVMDebugInfoGSYM was added. 
Please check the commit:

https://github.com/llvm/llvm-project/pull/139686/commits/ba55425db9fd8fd1ebb06a4c8d8c95eef213444f
That's the only change compare to
https://github.com/llvm/llvm-project/pull/134847



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications