[all-commits] [llvm/llvm-project] 06ca6e: [mlir][ArmSME] Remove `ConvertIllegalShapeCastOpsT...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Tue May 13 03:53:51 PDT 2025


  Branch: refs/heads/users/banach-space/sme/remove_ConvertIllegalShapeCastOpsToTransposes
  Home:   https://github.com/llvm/llvm-project
  Commit: 06ca6e9430b05f590fd0a437dd4363d65d3ee334
      https://github.com/llvm/llvm-project/commit/06ca6e9430b05f590fd0a437dd4363d65d3ee334
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2025-05-13 (Tue, 13 May 2025)

  Changed paths:
    M mlir/lib/Dialect/ArmSME/Transforms/VectorLegalization.cpp
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/ArmSME/vector-legalization.mlir
    M mlir/test/Dialect/Vector/canonicalize/vector-transpose.mlir

  Log Message:
  -----------
  [mlir][ArmSME] Remove `ConvertIllegalShapeCastOpsToTransposes`

As a follow-up to PR #135841 (see discussion for context), this patch
removes `ConvertIllegalShapeCastOpsToTransposes` from the SME legalization
pass and unblocks `ShapeCastOp::fold` for scalable vectors.

AFAIK, `ConvertIllegalShapeCastOpsToTransposes` was originally needed
because we were generating `vector.shape_cast` ops that couldn't be
lowered otherwise. To confirm it's no longer required, I tested this
patch locally using end-to-end tests.

Notably, this also removes a special case from `ShapeCastOp::fold`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list