[all-commits] [llvm/llvm-project] 70ca3f: [OpenMP] Fix crash on invalid with cancel directiv...

[Aaron Ballman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 70ca3f41fa1a16ede0b33e0780c04360b50e4dee
      https://github.com/llvm/llvm-project/commit/70ca3f41fa1a16ede0b33e0780c04360b50e4dee
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/Parse/ParseOpenMP.cpp
    M clang/test/OpenMP/cancel_messages.cpp

  Log Message:
  -----------
  [OpenMP] Fix crash on invalid with cancel directive (#139577)

If the next token after 'cancel' is a special token, we would trigger an
assertion. We should be consuming any token, same as elsewhere in the
function.

Note, we could check for an unknown directive and do different error
recovery, but that caused too many behavioral changes for other tests in
the form of "unexpected tokens ignored" diagnostics that didn't seem
like an improvement for the test cases.

Fixes #139360



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications