[all-commits] [llvm/llvm-project] dd3d7c: [HLSL][RootSignature] Define and integrate rootsig...

[Finn Plummer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd3d7cfe2e77f0f33b2952b1c965c87c9ea46eb4
      https://github.com/llvm/llvm-project/commit/dd3d7cfe2e77f0f33b2952b1c965c87c9ea46eb4
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-05-12 (Mon, 12 May 2025)

  Changed paths:
    M clang/include/clang/AST/Decl.h
    M clang/include/clang/AST/RecursiveASTVisitor.h
    M clang/include/clang/AST/TextNodeDumper.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DeclNodes.td
    M clang/include/clang/Parse/Parser.h
    M clang/include/clang/Sema/SemaHLSL.h
    M clang/lib/AST/CMakeLists.txt
    M clang/lib/AST/Decl.cpp
    M clang/lib/AST/DeclBase.cpp
    M clang/lib/AST/TextNodeDumper.cpp
    M clang/lib/CodeGen/CGDecl.cpp
    M clang/lib/Parse/ParseDeclCXX.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    M clang/lib/Serialization/ASTCommon.cpp
    A clang/test/AST/HLSL/RootSignatures-AST.hlsl
    A clang/test/SemaHLSL/RootSignature-err.hlsl
    M clang/tools/libclang/CIndex.cpp
    M llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h
    M llvm/lib/Frontend/HLSL/HLSLRootSignature.cpp

  Log Message:
  -----------
  [HLSL][RootSignature] Define and integrate rootsig clang attr and decl (#137690)

- Defines a new declaration node `HLSLRootSignature` in `DeclNodes.td`
that will consist of a `TrailingObjects` of the in-memory construction
of the root signature, namely an array of `hlsl::rootsig::RootElement`s

- Defines a new clang attr `RootSignature` which simply holds an
identifier to a corresponding root signature declaration as above

- Integrate the `HLSLRootSignatureParser` to construct the decl node in
`ParseMicrosoftAttributes` and then attach the parsed attr with an
identifier to the entry point function declaration.

- Defines the various required declaration methods

- Add testing that the declaration and reference attr are created
correctly, and some syntactical error tests.

It was previously proposed that we could have the root elements
reference be stored directly as an additional member of the attribute
and to not have a separate root signature decl. In contrast, by defining
them separately as this change proposes, we will allow a unique root
signature to have its own declaration in the AST tree. This allows us to
only construct a single root signature for all duplicate root signature
attributes. Having it located directly as a declaration might also prove
advantageous when we consider root signature libraries.

Resolves https://github.com/llvm/llvm-project/issues/119011



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications