[all-commits] [llvm/llvm-project] d9ac4d: [mlir][LLVMIR][NFC] Migrate to OpAsmAttrInterface ...
Hongren Zheng via All-commits
all-commits at lists.llvm.org
Mon May 12 02:21:35 PDT 2025
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: d9ac4d62f875948ffa8928f167d4765b922dc33e
https://github.com/llvm/llvm-project/commit/d9ac4d62f875948ffa8928f167d4765b922dc33e
Author: Hongren Zheng <i at zenithal.me>
Date: 2025-05-12 (Mon, 12 May 2025)
Changed paths:
M mlir/include/mlir/Dialect/LLVMIR/LLVMAttrDefs.td
M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
Log Message:
-----------
[mlir][LLVMIR][NFC] Migrate to OpAsmAttrInterface for ASM alias generation (#130479)
After the introduction of `OpAsmAttrInterface`, it is favorable to
migrate code using `OpAsmDialectInterface` for ASM alias generation,
which lives in `Dialect.cpp`, to use `OpAsmAttrInterface`, which lives
in `Attrs.td`. In this way, attribute behavior is placed near its
tablegen definition and people won't need to go through other files to
know what other (unexpected) hooks comes into play.
See #124721 for the interface itself and #128191 for prior migration for
Builtin Attributes.
See #131504 for the `genMnemonicAlias` tablegen field.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list