[all-commits] [llvm/llvm-project] 94ae5f: [clang][modules][deps] Implicit modules are out of...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94ae5f9e877be7490687c35ec9883ff9746721d6
      https://github.com/llvm/llvm-project/commit/94ae5f9e877be7490687c35ec9883ff9746721d6
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2025-05-09 (Fri, 09 May 2025)

  Changed paths:
    M clang/lib/Serialization/ModuleManager.cpp
    A clang/test/ClangScanDeps/modules-pch-common-stale.c

  Log Message:
  -----------
  [clang][modules][deps] Implicit modules are out of date when their explicit imports are (#138920)

The dependency scanner mixes implicitly- and explicitly-built modules.
When an implicitly-built module imports an explicitly-built one, we
never run the modification time validation checks, resulting in an
out-of-date module cache. This PR fixes that by only skipping the
modification time validation checks when both the imported module and
its importer are built explicitly.

rdar://150230022



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications