[all-commits] [llvm/llvm-project] 416cdc: clang/OpenCL: Fix special casing OpenCL in call em...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Fri May 9 05:16:18 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 416cdcf3aa75ea6a6dd4fe6f76a8d7251e06e0b3
      https://github.com/llvm/llvm-project/commit/416cdcf3aa75ea6a6dd4fe6f76a8d7251e06e0b3
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-05-09 (Fri, 09 May 2025)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp

  Log Message:
  -----------
  clang/OpenCL: Fix special casing OpenCL in call emission (#138864)

This essentially reverts 1bf1a156d673.

OpenCL's handling of address spaces has always been a mess, but it's
better than it used to be so this hack appears to be unnecessary now.

None of the code here should really depend on the language or language
address space. The ABI address space to use is already explicit in the
ABIArgInfo, so use that instead of guessing it has anything to do with
LangAS::Default or getASTAllocaAddressSpace.

The below usage of LangAS::Default and getASTAllocaAddressSpace are also
suspect, but appears to be a more involved and separate fix.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list