[all-commits] [llvm/llvm-project] 823b1a: [clang-installapi] Store dylib attributes in the o...

[Cyndy Ishida via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 823b1a582258f1417c648b3117ba08edc4855c68
      https://github.com/llvm/llvm-project/commit/823b1a582258f1417c648b3117ba08edc4855c68
  Author: Cyndy Ishida <cyndy_ishida at apple.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M clang/include/clang/InstallAPI/DylibVerifier.h
    M clang/lib/InstallAPI/DiagnosticBuilderWrappers.cpp
    M clang/lib/InstallAPI/DiagnosticBuilderWrappers.h
    M clang/lib/InstallAPI/DylibVerifier.cpp
    M clang/tools/clang-installapi/ClangInstallAPI.cpp
    M clang/tools/clang-installapi/Options.cpp

  Log Message:
  -----------
  [clang-installapi] Store dylib attributes in the order they are passed on the command line. (#139087)

With the introduction of tbd-v5 holding rpaths, the order in which those
attributes are passed to `clang-installapi` must be represented in tbd
files. Previously, all dylib attributes were stored in a
non-deterministic `StringMap`. Instead, hold them in a custom collection
with an underlying vector to continue supporting searching by attribute.
This makes the order of all diagnostics related to load command
comparisons stable.

This approach resolves errors when building with reverse-iteration.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications