[all-commits] [llvm/llvm-project] 6bb301: Branch island debug (#139166)

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6bb30196912daeaa92babc39519b2ae0bfce9771
      https://github.com/llvm/llvm-project/commit/6bb30196912daeaa92babc39519b2ae0bfce9771
  Author: jimingham <jingham at apple.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
    A lldb/test/API/macosx/branch-islands/Makefile
    A lldb/test/API/macosx/branch-islands/TestBranchIslands.py
    A lldb/test/API/macosx/branch-islands/foo.c
    A lldb/test/API/macosx/branch-islands/main.c
    A lldb/test/API/macosx/branch-islands/padding1.s
    A lldb/test/API/macosx/branch-islands/padding2.s
    A lldb/test/API/macosx/branch-islands/padding3.s
    A lldb/test/API/macosx/branch-islands/padding4.s

  Log Message:
  -----------
  Branch island debug (#139166)

This patch allows lldb to step in across "branch islands" which is the
Darwin linker's way of dealing with immediate branches to targets that
are too far away for the immediate slot to make the jump.

I submitted this a couple days ago and it failed on the arm64 bot. I was
able to match the bot OS and Tool versions (they are a bit old at this
point) and ran the test there but sadly it succeeded. The x86_64 bot
also failed but that was my bad, I did @skipUnlessDarwin when I should
have done @skipUnlessAppleSilicon.

So this resubmission is with the proper decoration for the test, and
with a bunch of debug output printed in case of failure. With any luck,
if this resubmission fails again I'll be able to see what's going on.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications