[all-commits] [llvm/llvm-project] 60d0bc: Propagate DebugLocs on phis in BreakCriticalEdges ...

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60d0bc1faeacb8be8ef38457bce0a4f0674bc575
      https://github.com/llvm/llvm-project/commit/60d0bc1faeacb8be8ef38457bce0a4f0674bc575
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp
    A llvm/test/Transforms/CodeGenPrepare/X86/split-dbg.ll

  Log Message:
  -----------
  Propagate DebugLocs on phis in BreakCriticalEdges (#133492)

The pull request discusses whether this change is needed or not. We leant
towards "it can't hurt" on the basis that it's at worst slightly unecessary
(but not incorret).

The motivation for the patch came from reviewing code duplication sites to
update for Key Instructions, finding this, trying to generate a test case and
seeing the DebugLocs aren't propagated.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications