[all-commits] [llvm/llvm-project] 0afaa2: [mlir][OpenMP] cancel(lation point) taskgroup LLVMIR

[Tom Eccles via All-commits]

  Branch: refs/heads/users/tblah/omp-cancel-codegen-4
  Home:   https://github.com/llvm/llvm-project
  Commit: 0afaa2ce77ab4ef6178c03f8a2a3d4377d190f7a
      https://github.com/llvm/llvm-project/commit/0afaa2ce77ab4ef6178c03f8a2a3d4377d190f7a
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M flang/docs/OpenMPSupport.md
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/openmp-cancel.mlir
    M mlir/test/Target/LLVMIR/openmp-cancellation-point.mlir
    M mlir/test/Target/LLVMIR/openmp-todo.mlir

  Log Message:
  -----------
  [mlir][OpenMP] cancel(lation point) taskgroup LLVMIR

A cancel or cancellation point for taskgroup is always nested inside of
a task inside of the taskgroup. For the task which is cancelled, it is
that task which needs to be cleaned up: not the owning taskgroup.
Therefore the cancellation branch handler is done in the conversion of
the task not in conversion of taskgroup.

I added a firstprivate clause to the test for cancel taskgroup to
demonstrate that the block being branched to is the same block where
mandatory cleanup code is added. Cancellation point follows exactly the
same code path.


  Commit: cbd71ceefb24015bf33f50b94920fb3cdf90c26d
      https://github.com/llvm/llvm-project/commit/cbd71ceefb24015bf33f50b94920fb3cdf90c26d
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  Add todo for cancelling a taskloop

No unit test can be written for this todo because there is no support at
all for lowering taskloop.


  Commit: 4212948eee6516d0e0a88f7b51809d8184bb1ae0
      https://github.com/llvm/llvm-project/commit/4212948eee6516d0e0a88f7b51809d8184bb1ae0
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2025-05-08 (Thu, 08 May 2025)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

  Log Message:
  -----------
  Keep calls to checkImplementationStatus


Compare: https://github.com/llvm/llvm-project/compare/3950bf232dcc...4212948eee65

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications