[all-commits] [llvm/llvm-project] abb68b: clang: Remove dest LangAS argument from performAdd...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed May 7 11:36:13 PDT 2025


  Branch: refs/heads/users/arsenm/clang/remove-dest-lang-as-from-performAddrSpaceCast
  Home:   https://github.com/llvm/llvm-project
  Commit: abb68b87e56fe5d1628180bcfa1a23e582cce81f
      https://github.com/llvm/llvm-project/commit/abb68b87e56fe5d1628180bcfa1a23e582cce81f
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M clang/lib/CodeGen/CGAtomic.cpp
    M clang/lib/CodeGen/CGBuiltin.cpp
    M clang/lib/CodeGen/CGCall.cpp
    M clang/lib/CodeGen/CGClass.cpp
    M clang/lib/CodeGen/CGDecl.cpp
    M clang/lib/CodeGen/CGException.cpp
    M clang/lib/CodeGen/CGExpr.cpp
    M clang/lib/CodeGen/CGExprCXX.cpp
    M clang/lib/CodeGen/CGExprConstant.cpp
    M clang/lib/CodeGen/CGExprScalar.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/CodeGen/TargetInfo.cpp
    M clang/lib/CodeGen/TargetInfo.h

  Log Message:
  -----------
  clang: Remove dest LangAS argument from performAddrSpaceCast

It isn't used and is redundant with the result pointer type argument.
A more reasonable API would only have LangAS parameters, or IR parameters,
not both. Not all values have a meaningful value for this. I'm also
not sure why we have this at all, it's not overridden by any targets and
further simplification is possible.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list