[all-commits] [llvm/llvm-project] c22081: [GlobalISel] Diagnose inline assembly constraint l...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c22081c320340d0e7542b247ee093ca515509b52
      https://github.com/llvm/llvm-project/commit/c22081c320340d0e7542b247ee093ca515509b52
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
    M llvm/test/CodeGen/AArch64/arm64-preserve-all.ll
    M llvm/test/CodeGen/AArch64/arm64-preserve-most.ll
    A llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-mismatched-size.ll

  Log Message:
  -----------
  [GlobalISel] Diagnose inline assembly constraint lowering errors (#135782)

Instead of printing something to dbgs (which is not visible to all users),
emit a diagnostic like the DAG does. We still crash later because we fail to
select the inline assembly, but at least now users will know why it's crashing.

In a future patch we could also recover from the error like the DAG does, so the
lowering can keep going until it either crashes or gives a different error later.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications