[all-commits] [llvm/llvm-project] 8e5d14: [GlobalISel] Diagnose inline assembly constraint l...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/users/pierre-vh/gisel-inlineasm-constraint-diag
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e5d146907bcd551e0622abf3e1c69ce7b4c79d8
      https://github.com/llvm/llvm-project/commit/8e5d146907bcd551e0622abf3e1c69ce7b4c79d8
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp

  Log Message:
  -----------
  [GlobalISel] Diagnose inline assembly constraint lowering errors

Instead of printing something to dbgs (which is not visible to all users),
emit a diagnostic like the DAG does. We still crash later because we fail to
select the inline assembly, but at least now users will know why it's crashing.

In a future patch we could also recover from the error like the DAG does, so the
lowering can keep going until it either crashes or gives a different error later.


  Commit: a7debaa8caa22a6aad4459f9d3c0160c05e85ddf
      https://github.com/llvm/llvm-project/commit/a7debaa8caa22a6aad4459f9d3c0160c05e85ddf
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
    A llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll

  Log Message:
  -----------
  add some tests


  Commit: b1ff22f9e36c281be8a603da3090ca688eff9796
      https://github.com/llvm/llvm-project/commit/b1ff22f9e36c281be8a603da3090ca688eff9796
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll

  Log Message:
  -----------
  fix tests


  Commit: 37703e73459c3734c35992e8426ad7b6aaa9fed3
      https://github.com/llvm/llvm-project/commit/37703e73459c3734c35992e8426ad7b6aaa9fed3
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll

  Log Message:
  -----------
  undef -> poison


  Commit: 34e68740dcb0d2a87adb6c0a99d2002b6ba9846c
      https://github.com/llvm/llvm-project/commit/34e68740dcb0d2a87adb6c0a99d2002b6ba9846c
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-mismatched-size.ll

  Log Message:
  -----------
  Fix tests


  Commit: ef0316a63924c85e35de14a692b1c015d4ad866d
      https://github.com/llvm/llvm-project/commit/ef0316a63924c85e35de14a692b1c015d4ad866d
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-05-07 (Wed, 07 May 2025)

  Changed paths:
    M llvm/test/CodeGen/AArch64/GlobalISel/arm64-fallback.ll
    M llvm/test/CodeGen/AArch64/arm64-preserve-all.ll
    M llvm/test/CodeGen/AArch64/arm64-preserve-most.ll

  Log Message:
  -----------
  Test updates


Compare: https://github.com/llvm/llvm-project/compare/b9c9e1e4a0e2...ef0316a63924

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications