[all-commits] [llvm/llvm-project] 2f54a8: [libc++][test] Test `flat_meow` with proper underl...

A. Jiang via All-commits all-commits at lists.llvm.org
Tue May 6 13:15:40 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f54a843bbbadbfaeb1a128eda075cc2e53b4fe0
      https://github.com/llvm/llvm-project/commit/2f54a843bbbadbfaeb1a128eda075cc2e53b4fe0
  Author: A. Jiang <de34 at live.cn>
  Date:   2025-05-06 (Tue, 06 May 2025)

  Changed paths:
    M libcxx/test/std/containers/container.adaptors/flat.map/flat.map.iterators/iterator_comparison.pass.cpp
    M libcxx/test/std/containers/container.adaptors/flat.multimap/flat.multimap.iterators/iterator_comparison.pass.cpp
    M libcxx/test/std/containers/container.adaptors/flat.multiset/flat.multiset.iterators/iterator_comparison.pass.cpp
    M libcxx/test/std/containers/container.adaptors/flat.set/flat.set.iterators/iterator_comparison.pass.cpp
    M libcxx/test/support/MinSequenceContainer.h
    M libcxx/test/support/test_iterators.h

  Log Message:
  -----------
  [libc++][test] Test `flat_meow` with proper underlying iterators (#131290)

Flat container adaptors require the iterators of underlying containers
to be random access, and it is required that random access container
iterators must support three-way comparison ([container.reqmts]/39 - /41).

As a result, we should at least avoid testing "containers" with random
access but not three-way comparable iterators for flat container
adaptors.

This patch adds a new class template `three_way_random_access_iterator`
to `test_iterators.h` and fixes some usages of `MinSequenceContainer`
with the new iterators.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list