[all-commits] [llvm/llvm-project] 5ec19d: [KeyInstr] Merge atoms in DILocation::getMergedLoc...

Orlando Cazalet-Hyams via All-commits all-commits at lists.llvm.org
Tue May 6 05:09:31 PDT 2025


  Branch: refs/heads/users/OCHyams/ki-llvm-merge
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ec19d6ecc9392dd3ee94bf0b5b4e1a87f636263
      https://github.com/llvm/llvm-project/commit/5ec19d6ecc9392dd3ee94bf0b5b4e1a87f636263
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-05-06 (Tue, 06 May 2025)

  Changed paths:
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  [KeyInstr] Merge atoms in DILocation::getMergedLocation

NFC for builds with LLVM_EXPERIMENTAL_KEY_INSTRUCTIONS=OFF (default).

In an ideal world we would be able to track that the merged location is used in
multiple source atoms. We can't do this though, so instead we arbitrarily but
deterministically pick one.

In cases where the InlinedAt field is unchanged we keep the atom with the
lowest non-zero rank (highest precedence). If the ranks are equal we choose
the smaller non-zero group number (arbitrary choice).

In cases where the InlinedAt field is adjusted we generate a new atom group.
Keeping the group wouldn't make sense (a source atom is identified by the
group number and InlinedAt pair) but discarding the atom info could result
in missed is_stmts.

Add unittest in MetadataTest.cpp.


  Commit: d90780eb51aeb547b5b70586a50f5d837e538b8b
      https://github.com/llvm/llvm-project/commit/d90780eb51aeb547b5b70586a50f5d837e538b8b
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-05-06 (Tue, 06 May 2025)

  Changed paths:
    M llvm/lib/IR/DebugInfoMetadata.cpp
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  param-comments and simplify lambda with early exits


  Commit: 5feaa9cb5eb31f2f90f7cf0c27b2b61874902ca8
      https://github.com/llvm/llvm-project/commit/5feaa9cb5eb31f2f90f7cf0c27b2b61874902ca8
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-05-06 (Tue, 06 May 2025)

  Changed paths:

  Log Message:
  -----------
  use new function names


  Commit: 6c4caf3d24379ee963caf89bc69544ad7538043f
      https://github.com/llvm/llvm-project/commit/6c4caf3d24379ee963caf89bc69544ad7538043f
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2025-05-06 (Tue, 06 May 2025)

  Changed paths:
    M llvm/unittests/IR/MetadataTest.cpp

  Log Message:
  -----------
  fix unittest


Compare: https://github.com/llvm/llvm-project/compare/1353653a8271...6c4caf3d2437

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list