[all-commits] [llvm/llvm-project] b492ec: [ErrorHandling] Add reportFatalInternalError + rep...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b492ec5899082af9f34d79be9750b5e5c5d082e1
      https://github.com/llvm/llvm-project/commit/b492ec5899082af9f34d79be9750b5e5c5d082e1
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-05-05 (Mon, 05 May 2025)

  Changed paths:
    M clang/lib/AST/ExternalASTSource.cpp
    M clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
    M llvm/include/llvm/CodeGen/CodeGenTargetMachineImpl.h
    M llvm/include/llvm/Passes/CodeGenPassBuilder.h
    M llvm/include/llvm/Support/Error.h
    M llvm/include/llvm/Support/ErrorHandling.h
    M llvm/lib/LTO/LTOBackend.cpp
    M llvm/lib/Support/Error.cpp
    M llvm/lib/Support/ErrorHandling.cpp
    M llvm/lib/Support/raw_ostream.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
    M llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
    M llvm/lib/Target/DirectX/DXILOpBuilder.cpp
    M llvm/lib/Target/DirectX/DXILResourceAccess.cpp
    M llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp
    M llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
    M llvm/lib/Target/RISCV/RISCVISelLowering.cpp
    M llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp
    M llvm/lib/Transforms/IPO/BlockExtractor.cpp
    M llvm/lib/Transforms/IPO/EmbedBitcodePass.cpp
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp
    M llvm/lib/Transforms/Scalar/LICM.cpp
    M llvm/lib/Transforms/Scalar/LoopPassManager.cpp
    M llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
    M llvm/tools/opt/optdriver.cpp
    M mlir/lib/TableGen/AttrOrTypeDef.cpp

  Log Message:
  -----------
  [ErrorHandling] Add reportFatalInternalError + reportFatalUsageError (NFC) (#138251)

This implements the result of the discussion at:

https://discourse.llvm.org/t/rfc-report-fatal-error-and-the-default-value-of-gencrashdialog/73587

There are two different use cases for report_fatal_error, so replace it
with two functions reportFatalInternalError() and
reportFatalUsageError(). The former indicates a bug in LLVM and
generates a crash dialog. The latter does not. The names have been
suggested by rnk and people seemed to like them.

This replaces a lot of the usages that passed an explicit value for
GenCrashDiag. I did not bulk replace remaining report_fatal_error usage
-- they probably require case by case review for which function to use.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications