[all-commits] [llvm/llvm-project] 49c2f7: [llvm][gvn-sink] Don't try to sink inline asm

[Paul Kirth via All-commits]

  Branch: refs/heads/users/ilovepi/gvn-sink-bug
  Home:   https://github.com/llvm/llvm-project
  Commit: 49c2f79ab5b8019694ec1f7e20c41e1a01372a52
      https://github.com/llvm/llvm-project/commit/49c2f79ab5b8019694ec1f7e20c41e1a01372a52
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2025-05-03 (Sat, 03 May 2025)

  Changed paths:
    M llvm/lib/Transforms/Scalar/GVNSink.cpp
    A llvm/test/Transforms/GVNSink/pr138345.ll

  Log Message:
  -----------
  [llvm][gvn-sink] Don't try to sink inline asm

Fixes #138345. Before this patch, gvn-sink would try to sink inline
assembly statements. Other GVN passes avoid them (see
https://github.com/llvm/llvm-project/blob/b4fac94181c4cf17dbb7ecc2ae975712b0e4a6d1/llvm/lib/Transforms
Similarly, gvn-sink should skip these instructions, since they are not
safe to move.

The test added is reduced from a failure when compiling Fuchsia. There
were two distinct failure modes. One occurred when only running gvn-sink
alone, but a different failure happened when running
correlated-propagation afterwards.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications