[all-commits] [llvm/llvm-project] 0ddcd2: Don't hold the Target's ModuleListLock over runnin...

jimingham via All-commits all-commits at lists.llvm.org
Fri May 2 11:51:42 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ddcd209ddc8956eb52d642937a4397c6b08449c
      https://github.com/llvm/llvm-project/commit/0ddcd209ddc8956eb52d642937a4397c6b08449c
  Author: jimingham <jingham at apple.com>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M lldb/source/Core/ModuleList.cpp

  Log Message:
  -----------
  Don't hold the Target's ModuleListLock over running LoadScriptingResourceInTarget (#138216)

That calls an unknown amount of Python code, and can do quite a bit of
work - especially if people do things like launch scripted processes in
this script affordance. Doing that while holding a major lock like the
ModuleList lock is asking for trouble.

I tried to make a test that would actually stall without this, but I
couldn't come up with anything that reliably failed. You always have to
get pretty unlucky.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list