[all-commits] [llvm/llvm-project] 8313d2: [OpenACC] Fixup previous-clause diagnostics

[Erich Keane via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8313d2a8dbc5e23741d7c67c3b009fc3f6de4875
      https://github.com/llvm/llvm-project/commit/8313d2a8dbc5e23741d7c67c3b009fc3f6de4875
  Author: erichkeane <ekeane at nvidia.com>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaOpenACC.cpp
    M clang/lib/Sema/SemaOpenACCClause.cpp
    M clang/lib/Sema/SemaOpenACCClauseAppertainment.cpp
    M clang/test/ParserOpenACC/parse-clauses.c
    M clang/test/SemaOpenACC/atomic-construct.cpp
    M clang/test/SemaOpenACC/combined-construct-auto_seq_independent-clauses.c
    M clang/test/SemaOpenACC/combined-construct-default-clause.c
    M clang/test/SemaOpenACC/combined-construct-default-clause.cpp
    M clang/test/SemaOpenACC/combined-construct-device_type-clause.c
    M clang/test/SemaOpenACC/combined-construct-gang-clause.cpp
    M clang/test/SemaOpenACC/combined-construct-num_gangs-clause.c
    M clang/test/SemaOpenACC/combined-construct-num_workers-clause.c
    M clang/test/SemaOpenACC/combined-construct-reduction-clause.cpp
    M clang/test/SemaOpenACC/combined-construct-self-clause.c
    M clang/test/SemaOpenACC/combined-construct-self-clause.cpp
    M clang/test/SemaOpenACC/combined-construct-vector-clause.cpp
    M clang/test/SemaOpenACC/combined-construct-vector_length-clause.c
    M clang/test/SemaOpenACC/combined-construct-worker-clause.cpp
    M clang/test/SemaOpenACC/compute-construct-async-clause.c
    M clang/test/SemaOpenACC/compute-construct-default-clause.c
    M clang/test/SemaOpenACC/compute-construct-default-clause.cpp
    M clang/test/SemaOpenACC/compute-construct-device_type-clause.c
    M clang/test/SemaOpenACC/compute-construct-num_gangs-clause.c
    M clang/test/SemaOpenACC/compute-construct-num_workers-clause.c
    M clang/test/SemaOpenACC/compute-construct-reduction-clause.c
    M clang/test/SemaOpenACC/compute-construct-reduction-clause.cpp
    M clang/test/SemaOpenACC/compute-construct-self-clause.c
    M clang/test/SemaOpenACC/compute-construct-self-clause.cpp
    M clang/test/SemaOpenACC/compute-construct-vector_length-clause.c
    M clang/test/SemaOpenACC/data-construct-async-clause.c
    M clang/test/SemaOpenACC/data-construct-default-clause.c
    M clang/test/SemaOpenACC/data-construct-device_type-clause.c
    M clang/test/SemaOpenACC/data-construct-if-clause.c
    M clang/test/SemaOpenACC/data-construct.cpp
    M clang/test/SemaOpenACC/init-construct.cpp
    M clang/test/SemaOpenACC/loop-construct-auto_seq_independent-clauses.c
    M clang/test/SemaOpenACC/loop-construct-collapse-clause.cpp
    M clang/test/SemaOpenACC/loop-construct-device_type-clause.c
    M clang/test/SemaOpenACC/loop-construct-gang-clause.cpp
    M clang/test/SemaOpenACC/loop-construct-reduction-clause.cpp
    M clang/test/SemaOpenACC/loop-construct-tile-clause.cpp
    M clang/test/SemaOpenACC/loop-construct-vector-clause.cpp
    M clang/test/SemaOpenACC/loop-construct-worker-clause.cpp
    M clang/test/SemaOpenACC/routine-construct-clauses.cpp
    M clang/test/SemaOpenACC/set-construct.cpp
    M clang/test/SemaOpenACC/shutdown-construct.cpp
    M clang/test/SemaOpenACC/update-construct.cpp

  Log Message:
  -----------
  [OpenACC] Fixup previous-clause diagnostics

Brought up in a previous review as a TODO, we could be better about how
we highlight what hte previous clause was, and how to show that the
'device_type' is the one being targetted.  This patch rewords the
diagnostics and updates a massive number of tests.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications