[all-commits] [llvm/llvm-project] b5dbdd: [DAG] visitEXTRACT_SUBVECTOR - change fold helper ...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Fri May 2 09:25:19 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b5dbddd2004a42a8c80dc38e9571b4d29b395d17
      https://github.com/llvm/llvm-project/commit/b5dbddd2004a42a8c80dc38e9571b4d29b395d17
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  [DAG] visitEXTRACT_SUBVECTOR - change fold helper methods to take operands instead of EXTRACT_SUBVECTOR node. NFC. (#138279)

Call with the individual subvector type, source vector and index operands instead of the original EXTRACT_SUBVECTOR node.

Some of these folds still assumed that EXTRACT_SUBVECTOR/INSERT_SUBVECTOR nodes could have variable indices, despite us moving to all constant indices some time ago - all of that code has now been simplified.

I've moved the narrowExtractedVectorBinOp call higher up, but it won't affect fold order - it didn't rely on the peekThroughBitcasts call, and worked on BinOps, not BUILD_VECTOR/INSERT_SUBVECTOR nodes.

Prep work to make it easier for more of these folds to work through BITCAST nodes.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list