[all-commits] [llvm/llvm-project] 7220fd: [flang] Hide strict volatility checks behind flag ...

[Asher Mancinelli via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7220fdad0cbf42a9d134e157ba5821192327f4f3
      https://github.com/llvm/llvm-project/commit/7220fdad0cbf42a9d134e157ba5821192327f4f3
  Author: Asher Mancinelli <ashermancinelli at gmail.com>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M flang/include/flang/Optimizer/Dialect/FIROps.h
    M flang/lib/Optimizer/Dialect/FIROps.cpp
    M flang/lib/Optimizer/HLFIR/IR/HLFIROps.cpp
    M flang/test/Fir/invalid.fir
    M flang/test/Fir/volatile.fir
    M flang/test/Fir/volatile2.fir
    M flang/test/HLFIR/volatile.fir
    M flang/test/HLFIR/volatile1.fir
    M flang/test/HLFIR/volatile2.fir
    M flang/test/HLFIR/volatile3.fir
    M flang/test/HLFIR/volatile4.fir
    A flang/test/Lower/volatile-allocatable1.f90
    M flang/test/Lower/volatile-openmp.f90
    M flang/test/Lower/volatile-string.f90
    M flang/test/Lower/volatile1.f90
    M flang/test/Lower/volatile2.f90
    M flang/test/Lower/volatile3.f90
    M flang/test/Lower/volatile4.f90

  Log Message:
  -----------
  [flang] Hide strict volatility checks behind flag (#138183)

Enabling volatility lowering by default revealed some issues in lowering
and op verification.

For example, given volatile variable of a nested type, accessing
structure members of a structure member would result in a volatility
mismatch when the inner structure member is designated (and thus a
verification error at compile time).

In other cases, I found correct codegen when the checks were disabled,
also related to allocatable types and how we handle volatile references
of boxes.

This hides the strict verification of fir and hlfir ops behind a flag so
I can iteratively improve lowering of volatile variables without causing
compile-time failures, keeping the strict verification on when running
tests.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications