[all-commits] [llvm/llvm-project] f6ac52: [Offload] Ensure all `llvm::Error`s are handled (#...

[Ross Brunton via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f6ac5276ee364b3b22ce746439e0ce3224dc9091
      https://github.com/llvm/llvm-project/commit/f6ac5276ee364b3b22ce746439e0ce3224dc9091
  Author: Ross Brunton <ross at codeplay.com>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M offload/liboffload/include/OffloadImpl.hpp
    M offload/liboffload/src/OffloadImpl.cpp
    M offload/unittests/OffloadAPI/kernel/olGetKernel.cpp

  Log Message:
  -----------
  [Offload] Ensure all `llvm::Error`s are handled (#137339)

`llvm::Error`s containing errors must be explicitly handled or an assert
will be raised. With this change, `ol_impl_result_t` can accept and
consume an `llvm::Error` for errors raised by PluginInterface that have
multiple causes and other places now call `llvm::consumeError`.

Note that there is currently no facility for PluginInterface to
communicate exact error codes, but the constructor is designed in
such a way that it can be easily added later. This MR is to
convert a crash into an error code.

A new test was added, however due to the aforementioned issue with
error codes, it does not pass and instead is marked as a skip.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications