[all-commits] [llvm/llvm-project] 40edb3: [StackSlotColoring] Fix issue where colors for a S...

Benjamin Maxwell via All-commits all-commits at lists.llvm.org
Fri May 2 02:24:00 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 40edb37bb370541b71657fc308ba26b1ec2deb16
      https://github.com/llvm/llvm-project/commit/40edb37bb370541b71657fc308ba26b1ec2deb16
  Author: Benjamin Maxwell <benjamin.maxwell at arm.com>
  Date:   2025-05-02 (Fri, 02 May 2025)

  Changed paths:
    M llvm/lib/CodeGen/StackSlotColoring.cpp

  Log Message:
  -----------
  [StackSlotColoring] Fix issue where colors for a StackID are dropped (#138140)

In InitializeSlots, if an interval with a non-zero StackID (A) is
encountered we set All/UsedColors to a size of A + 1. If after this we
process another interval with a non-zero StackID (B), where B < A, then
we resize All/UsedColors to size < A + 1, and lose the BitVector
associated with A.

AFAIK this is a latent bug upstream, but when adding a new TargetStackID
locally I hit a `NextColors[StackID] != -1 && "No more spill slots?"`
assertion due to this issue.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list