[all-commits] [llvm/llvm-project] 4fdb8c: Make stop-hooks fire when lldb first gains control...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
      https://github.com/llvm/llvm-project/commit/4fdb8cb42f73ebec9a3bdd37b2f27c222f9afd87
  Author: jimingham <jingham at apple.com>
  Date:   2025-05-01 (Thu, 01 May 2025)

  Changed paths:
    M lldb/include/lldb/Target/Target.h
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Commands/Options.td
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
    M lldb/test/API/commands/target/stop-hooks/TestStopHooks.py
    A lldb/test/API/commands/target/stop-hooks/on-core-load/TestStopHookOnCoreLoad.py
    A lldb/test/API/commands/target/stop-hooks/on-core-load/linux-x86_64.core
    A lldb/test/API/commands/target/stop-hooks/on-core-load/stop_hook.py
    A lldb/test/API/commands/target/stop-hooks/on-core-load/test.core.yaml
    M lldb/test/API/python_api/event/TestEvents.py

  Log Message:
  -----------
  Make stop-hooks fire when lldb first gains control of a process. (#137410)

stop-hooks are supposed to trigger every time the process stops, but as
initially implemented they would only fire when control was returned to
the user. So for instance when a process was launched the stop hook
would only trigger when the process hit a breakpoint or crashed.

However, it would be really useful to be able to trigger a stop hook
when lldb first gains control over the process. One way to do that would
be to implement general "target lifecycle events" and then send process
created events that users could bind actions to.

OTOH, extending the stop hooks to fire when lldb first gains control
over the process is a pretty natural extension to the notion of a stop
hook. So this patch takes the shorter route to that ability by making
stop-hooks fire when lldb first gains control over the process.

I also added the ability to specify whether to trigger the stop hook "on
gaining control". I'm on the fence about whether to set the default to
be "trigger on gaining control" or "don't trigger on gaining control".
Since I think it's a generally useful feature, I've set the default to
"trigger on gaining control".



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications