[all-commits] [llvm/llvm-project] 38cb7d: [IR] Don't allow label arguments (#137799)

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 38cb7d5e7591cdfb39d1030480920ec1ce4873c6
      https://github.com/llvm/llvm-project/commit/38cb7d5e7591cdfb39d1030480920ec1ce4873c6
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2025-04-30 (Wed, 30 Apr 2025)

  Changed paths:
    M llvm/docs/ReleaseNotes.md
    M llvm/lib/AsmParser/LLParser.cpp
    M llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
    M llvm/lib/IR/Type.cpp
    M llvm/lib/IR/Verifier.cpp
    A llvm/test/Assembler/invalid-label-call-arg.ll
    M llvm/test/Assembler/invalid-label.ll
    M llvm/test/CodeGen/X86/asm-block-labels.ll
    M llvm/test/Verifier/invalid-label-param.ll

  Log Message:
  -----------
  [IR] Don't allow label arguments (#137799)

We currently accept label arguments to inline asm calls. This support
predates both blockaddresses and callbr and is only covered by one X86
test. Remove it in favor of callbr (or at least blockaddress, though
that cannot guarantee correct codegen, just like using block labels
directly can't).

I didn't bother implementing bitcode upgrade support for this, but I can
add it if desired.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications