[all-commits] [llvm/llvm-project] 705cef: [TargetParser] Fix flaky installs of generated hea...

[Shoaib Meenai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 705ceff7c1fc328151a6506a91773aac429ccee3
      https://github.com/llvm/llvm-project/commit/705ceff7c1fc328151a6506a91773aac429ccee3
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2025-04-29 (Tue, 29 Apr 2025)

  Changed paths:
    M clang/lib/AST/CMakeLists.txt
    M clang/lib/Basic/CMakeLists.txt
    M clang/lib/CodeGen/CMakeLists.txt
    M clang/lib/Driver/CMakeLists.txt
    M clang/tools/driver/CMakeLists.txt
    M llvm/CMakeLists.txt
    M llvm/cmake/modules/LLVMConfig.cmake.in
    M llvm/include/llvm/TargetParser/CMakeLists.txt
    M llvm/lib/TargetParser/CMakeLists.txt

  Log Message:
  -----------
  [TargetParser] Fix flaky installs of generated headers (#137853)

The `llvm-headers` target wasn't depending on the generated TargetParser
headers, so they'd be flakily installed or not installed depending on
which order the build steps ran in. Add an explicit dependency to fix
this, and switch to a single `target_parser_gen` target to mirror the
pattern used by `intrinsics_gen` (which also fixes a few other missing
dependencies). Switch `llvm-headers` to use `add_dependencies` instead
of `DEPENDS` for the tablegen dependencies as well, since `DEPENDS` is
only intended for creating a file-level dependency on the output of an
`add_custom_command` in the same CMakeLists.txt (see `DEPENDS` under
https://cmake.org/cmake/help/latest/command/add_custom_target.html).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications