[all-commits] [llvm/llvm-project] ad66e5: [DirectX] Revise descriptions of DXIL module flags...

[Deric C. via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ad66e5495d598c9f64cfafba92ba48f2a24b8278
      https://github.com/llvm/llvm-project/commit/ad66e5495d598c9f64cfafba92ba48f2a24b8278
  Author: Deric C. <cheung.deric at gmail.com>
  Date:   2025-04-29 (Tue, 29 Apr 2025)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/DXContainerConstants.def
    M llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-cs.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/disable-opt-lib.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/low-precision.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/raw-and-structured-buffers.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/res-may-alias-0.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/res-may-alias-1.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/res-may-not-alias-sm6.6.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/res-may-not-alias-sm6.7.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/res-may-not-alias-valver1.8.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/use-native-low-precision-0.ll
    M llvm/test/CodeGen/DirectX/ShaderFlags/use-native-low-precision-1.ll
    M llvm/test/ObjectYAML/DXContainer/DomainMaskVectors.yaml
    M llvm/test/ObjectYAML/DXContainer/GeometryMaskVectors.yaml
    M llvm/test/ObjectYAML/DXContainer/HullMaskVectors.yaml
    M llvm/test/tools/obj2yaml/DXContainer/ShaderFlags.yaml
    M llvm/test/tools/obj2yaml/DXContainer/ShaderFlagsEmpty.yaml

  Log Message:
  -----------
  [DirectX] Revise descriptions of DXIL module flags (#133543)

This PR revises the descriptions of DXIL module flags.

Descriptions such as `D3D11_1_SB_GLOBAL_FLAG_SKIP_OPTIMIZATION` are
referring to Global Flags in DXBC.
DXBC is not a supported backend target, so references to DXBC should not
be present.

There is also confusion with regards to the description of the
`LowPrecisionPresent` DXIL module flag, which currently reads
`D3D11_1_SB_GLOBAL_FLAG_ENABLE_MINIMUM_PRECISION` and implies the use of
minimum-precision to handle 16-bit types.
However this is not true, because both the flags `LowPrecisionPresent`
and `UseNativeLowPrecision` can simultaneously be set in the same DXIL
module, and minimum precision mode is mutually exclusive with native low
precision.
This PR revises the description of the `LowPrecisionPresent` flag to
accurately describe what it represents.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications