[all-commits] [llvm/llvm-project] e4d2ff: [SelectionDAG][PowerPC] Remove setTruncatingStore ...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e4d2ff5b014250e2707b52b6d59f5bf9e393c7bf
      https://github.com/llvm/llvm-project/commit/e4d2ff5b014250e2707b52b6d59f5bf9e393c7bf
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2025-04-28 (Mon, 28 Apr 2025)

  Changed paths:
    M llvm/include/llvm/CodeGen/SelectionDAGNodes.h
    M llvm/lib/Target/PowerPC/PPCISelLowering.cpp

  Log Message:
  -----------
  [SelectionDAG][PowerPC] Remove setTruncatingStore from StoreSDNode. (#137667)

Mutating a node after it has been created isn't a good idea. After
e17f07c4debbe76f5ebcdeeda619e7438700e2ad, we have a version of setStore
that can create a truncating indexed store. Use that instead of
MorphNodeTo+setTruncatingStore in PowerPC.

Unfortunately, if we return the newly created node, DAGCombiner will
visit the node and change the constant. To prevent this, we use
DCI.CombineTo and avoid adding the new node to the worklist.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications