[all-commits] [llvm/llvm-project] e73134: [mlir][ptr] Switch `LogicalResult` to `bool` in `M...

Fabian Mora via All-commits all-commits at lists.llvm.org
Sun Apr 27 08:16:24 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e7313421f1ad2e269a55e1f31280936d8d5395a3
      https://github.com/llvm/llvm-project/commit/e7313421f1ad2e269a55e1f31280936d8d5395a3
  Author: Fabian Mora <fmora.dev at gmail.com>
  Date:   2025-04-27 (Sun, 27 Apr 2025)

  Changed paths:
    M mlir/include/mlir/Dialect/Ptr/IR/MemorySpaceInterfaces.td
    M mlir/lib/Dialect/Ptr/IR/PtrAttrs.cpp
    M mlir/test/lib/Dialect/Test/TestAttributes.cpp

  Log Message:
  -----------
  [mlir][ptr] Switch `LogicalResult` to `bool` in `MemorySpaceAttrInterrface` (#137513)

This patch switches the return type in `MemorySpaceAttrInterface`
methods from `LogicalResult` to `bool`. As `is*` methods are predicates.

Users of the `MemorySpaceAttrInterface` API must note that, if
`emitError` is non-null and the result of a `is*` method is `false`,
then an error was likely emitted. To avoid the emission of an error the
user can pass a default constructed `emitError`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list