[all-commits] [llvm/llvm-project] d76ec6: [lldb] Fix SBTarget::ReadInstruction with flavor...

[David Spickett via All-commits]

  Branch: refs/heads/release/20.x
  Home:   https://github.com/llvm/llvm-project
  Commit: d76ec6a75d398f35769d81dfd86a026d6801e71e
      https://github.com/llvm/llvm-project/commit/d76ec6a75d398f35769d81dfd86a026d6801e71e
  Author: Ebuka Ezike <yerimyah1 at gmail.com>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M lldb/source/API/SBTarget.cpp
    A lldb/test/API/python_api/target/read-instructions-flavor/Makefile
    A lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py
    A lldb/test/API/python_api/target/read-instructions-flavor/main.c

  Log Message:
  -----------
  [lldb] Fix  SBTarget::ReadInstruction  with flavor (#134626)

When you call the `SBTarget::ReadInstructions` with flavor from lldb
crashes. This is because the wrong order of the `DisassemblyBytes`
constructor this fixes that

---------

Signed-off-by: Ebuka Ezike <yerimyah1 at gmail.com>


  Commit: 8f288eb619db306deace61d325ca7913aa4bd491
      https://github.com/llvm/llvm-project/commit/8f288eb619db306deace61d325ca7913aa4bd491
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M lldb/test/API/python_api/target/read-instructions-flavor/TestTargetReadInstructionsFlavor.py

  Log Message:
  -----------
  [lldb][test] Adjust TestTargetReadInstructionsFlavor skipIfs

Original in https://github.com/llvm/llvm-project/pull/134626 was
written as if it was "this or this" but it's "this and this".

So the test ran on AArch64 Linux, because Linux is not Windows.

Split out the Windows check to fix that.


Compare: https://github.com/llvm/llvm-project/compare/62072e7f877e...8f288eb619db

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications