[all-commits] [llvm/llvm-project] 92d1d8: [NFC][HLSL][RootSignature] Move `HLSLRootSignature...

Finn Plummer via All-commits all-commits at lists.llvm.org
Fri Apr 25 11:41:37 PDT 2025


  Branch: refs/heads/users/inbelic/pr-137381
  Home:   https://github.com/llvm/llvm-project
  Commit: 92d1d83b3fbb43523819b5be338922ab614d2054
      https://github.com/llvm/llvm-project/commit/92d1d83b3fbb43523819b5be338922ab614d2054
  Author: Finn Plummer <canadienfinn at gmail.com>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    R clang/include/clang/Parse/ParseHLSLRootSignature.h
    A clang/include/clang/Sema/ParseHLSLRootSignature.h
    M clang/lib/Parse/CMakeLists.txt
    R clang/lib/Parse/ParseHLSLRootSignature.cpp
    M clang/lib/Sema/CMakeLists.txt
    A clang/lib/Sema/ParseHLSLRootSignature.cpp
    M clang/unittests/CMakeLists.txt
    R clang/unittests/Parse/CMakeLists.txt
    R clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp
    M clang/unittests/Sema/CMakeLists.txt
    A clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp

  Log Message:
  -----------
  [NFC][HLSL][RootSignature] Move `HLSLRootSignatureParser` into clangSema

Noting:
- Currently, `HLSLRootSignatureParser` is defined in `clangParse`, as it
would naturally seem an appropriate place to place.

- Surprisingly, `clangParse` has a dependency on `clangSema`. So we can't
introduce a dependency of `clangSema` onto `clangParse`.

- Given the users of `HLSLRootSignatureParser` will be `SemaHLSL` when
parsing from source and `clangFrontend` when we are parsing as a
command line argument.

- Therefore, we are required to move this out of `clangParse` so that
`clangSema` can reference it.

This commit moves `HLSLRootSignatureParser` into `clangSema` so it can
be linked to all its dependencies (`clangFrontend` already depends on
`clangSema`)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list