[all-commits] [llvm/llvm-project] 332e18: [lldb] Fix error that lead Windows to think it cou...

David Spickett via All-commits all-commits at lists.llvm.org
Fri Apr 25 10:04:29 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 332e1817667827c242422e91c4de1b27fb573a0b
      https://github.com/llvm/llvm-project/commit/332e1817667827c242422e91c4de1b27fb573a0b
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/test/API/commands/process/reverse-continue/TestReverseContinueNotSupported.py

  Log Message:
  -----------
  [lldb] Fix error that lead Windows to think it could reverse execute (#137351)

The new test added in https://github.com/llvm/llvm-project/pull/132783
was failing on Windows because it created a new error to say it did not
support the feature, but then returned the existing, default constructed
error. Which was a success value.

This also changes the GDBRemote error message to the same phrasing used
in all the other places so we don't have to special case any platform.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list