[all-commits] [llvm/llvm-project] 5cd97a: [GlobalISel] Diagnose inline assembly constraint l...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/users/pierre-vh/gisel-inlineasm-constraint-diag
  Home:   https://github.com/llvm/llvm-project
  Commit: 5cd97ac8a8f0e77cf540df0f99d1ad34f4f04b20
      https://github.com/llvm/llvm-project/commit/5cd97ac8a8f0e77cf540df0f99d1ad34f4f04b20
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp

  Log Message:
  -----------
  [GlobalISel] Diagnose inline assembly constraint lowering errors

Instead of printing something to dbgs (which is not visible to all users),
emit a diagnostic like the DAG does. We still crash later because we fail to
select the inline assembly, but at least now users will know why it's crashing.

In a future patch we could also recover from the error like the DAG does, so the
lowering can keep going until it either crashes or gives a different error later.


  Commit: 2a3f542b81147d72cd121e6e5c718df52d8f753e
      https://github.com/llvm/llvm-project/commit/2a3f542b81147d72cd121e6e5c718df52d8f753e
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp
    A llvm/test/CodeGen/AMDGPU/GlobalISel/inline-asm-lowering-errors.ll

  Log Message:
  -----------
  add some tests


Compare: https://github.com/llvm/llvm-project/compare/18fddacf58da...2a3f542b8114

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications