[all-commits] [llvm/llvm-project] 216845: [AMDGPU][SplitModule] Do not create empty modules ...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2168455ef4cdbec9df3b63900fe9b316154187cf
      https://github.com/llvm/llvm-project/commit/2168455ef4cdbec9df3b63900fe9b316154187cf
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/test/tools/llvm-split/AMDGPU/address-taken-externalize-with-call.ll
    M llvm/test/tools/llvm-split/AMDGPU/large-kernels-merging-weak_odr.ll
    M llvm/test/tools/llvm-split/AMDGPU/large-kernels-merging.ll
    A llvm/test/tools/llvm-split/AMDGPU/preserve-globals.ll

  Log Message:
  -----------
  [AMDGPU][SplitModule] Do not create empty modules (#135761)

Skip creating a module if no function is going to be imported.
Also includes a change so that if the first partition is empty (which
can happen),
we import global with non-local linkage into the first non-empty
partition, instead
of P0 all the time.

I thought we'd need to change users of the SplitModule callback so they
can deal with less modules
than the number requested, but no. We already return only 1 module in
some cases and
it seems to be handled just fine.

Fixes SWDEV-523146



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications