[all-commits] [llvm/llvm-project] 8c2233: [mlir][vector] Update docs + add tests (#137144)

Andrzej Warzyński via All-commits all-commits at lists.llvm.org
Thu Apr 24 23:42:42 PDT 2025


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8c2233b304dcdac0a6edb61a3cc5f9cb97c382bc
      https://github.com/llvm/llvm-project/commit/8c2233b304dcdac0a6edb61a3cc5f9cb97c382bc
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M mlir/lib/Dialect/Vector/IR/VectorOps.cpp
    M mlir/test/Dialect/Vector/invalid.mlir

  Log Message:
  -----------
  [mlir][vector] Update docs + add tests (#137144)

This is a small follow-on for #133721:
* Renamed `getRealVectorRank` as `getEffectiveVectorRankForXferOp` (to
  emphasise that this method was written specifically for transfer Ops).
* Marginally tweaked the description for
  `getEffectiveVectorRankForXferOp` (mostly to highlight the two edge
  cases being covered).
* Added tests for cases when the element type (of the shaped type) is a
  vector.
* Unified the naming (and the order) of arguments in tests with the
  surrounding tests (e.g. `%vec_to_write` -> `%arg1`). Mostly for
  consistency (it would be good to use self-documenting names like
  `%vec_to_write` throughout).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list