[all-commits] [llvm/llvm-project] 0975c0: [clang][p2719] Module deserialization does not res...

[Oliver Hunt via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0975c09c671aca48c25b1f5952a675931ae93702
      https://github.com/llvm/llvm-project/commit/0975c09c671aca48c25b1f5952a675931ae93702
  Author: Oliver Hunt <oliver at apple.com>
  Date:   2025-04-24 (Thu, 24 Apr 2025)

  Changed paths:
    M clang/lib/Serialization/ASTReaderDecl.cpp
    M clang/lib/Serialization/ASTWriterDecl.cpp
    A clang/test/Modules/Inputs/PR137102/module.modulemap
    A clang/test/Modules/Inputs/PR137102/type_aware_destroying_new_delete.h
    A clang/test/Modules/type-aware-destroying-new-and-delete-modules.cpp
    A clang/test/PCH/Inputs/type_aware_destroying_new_delete.h
    A clang/test/PCH/type-aware-destroying-new-and-delete-pch.cpp

  Log Message:
  -----------
  [clang][p2719] Module deserialization does not restore allocator flags (#137102)

When serializing and deserializing a FunctionDecl we don't recover
whether or not the decl was a type aware allocator or destroying delete,
because in the final PR that information was placed in a side table in
ASTContext.

In principle it should be possible to re-do the semantic checks to
determine what these flags should be when deserializing, but it seems
like the most robust path is simply recording the flags directly in the
serialized AST.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications