[all-commits] [llvm/llvm-project] 1fd0b4: [lldb/DWARF] Remove "range lower than function low...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1fd0b41b44603c190f507f222c16d9f98470f89d
      https://github.com/llvm/llvm-project/commit/1fd0b41b44603c190f507f222c16d9f98470f89d
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2025-04-23 (Wed, 23 Apr 2025)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
    R lldb/test/Shell/SymbolFile/DWARF/range-lower-then-low-pc.s
    M lldb/test/Shell/SymbolFile/DWARF/x86/discontinuous-inline-function.s

  Log Message:
  -----------
  [lldb/DWARF] Remove "range lower than function low_pc" check (#132395)

The check is not correct for discontinuous functions, as one of the
blocks could very well begin before the function entry point. To catch
dead-stripped ranges, I check whether the functions is after the first
known code address. I don't print any error in this case as that is a
common/expected situation.

This avoids many errors like:
```
error: ld-linux-x86-64.so.2 0x00085f3b: adding range [0x0000000000001ae8-0x0000000000001b07) which has a 
base that is less than the function's low PC 0x000000000001cfb0. Please file a bug and attach the file at
 the start of this error message
```
when debugging binaries on debian trixie because the dynamic linker
(ld-linux) contains discontinuous functions.

If the block ranges is not a subrange of the enclosing block then this
will range will currently be added to the outer block as well (i.e., we
get the same behavior that's currently possible for non-subrange blocks
larger than function_low_pc). However, this code path is buggy and I'd
like to change that (#117725).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications