[all-commits] [llvm/llvm-project] 84cd0d: [lldb] Slide eh_frame unwind plan if it doesn't be...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 84cd0d3c38e40e4cb5e416684ecd84df914e19aa
      https://github.com/llvm/llvm-project/commit/84cd0d3c38e40e4cb5e416684ecd84df914e19aa
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M lldb/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp
    M lldb/source/Symbol/DWARFCallFrameInfo.cpp
    M lldb/source/Symbol/UnwindPlan.cpp
    M lldb/test/Shell/Unwind/Inputs/eh-frame-small-fde.s
    M lldb/test/Shell/Unwind/eh-frame-small-fde.test
    M lldb/unittests/Symbol/UnwindPlanTest.cpp

  Log Message:
  -----------
  [lldb] Slide eh_frame unwind plan if it doesn't begin at function boundary (#135333)

This is mainly useful for discontinuous functions because individual
parts of the function will have separate FDE entries, which can begin
many megabytes from the start of the function. However, I'm separating
it out, because it turns out we already have a test case for the
situation where the FDE does not begin exactly at the function boundary.

The test works mostly by accident because the FDE starts only one byte
after the beginning of the function so it doesn't really matter whether
one looks up the unwind row using the function or fde offset. In this
patch, I beef up the test to catch this problem more reliably.

To make this work I've also needed to change a couple of places which
that an unwind plan always has a row at offset zero.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications