[all-commits] [llvm/llvm-project] 0609a3: [GlobalISel] Add `combine` action for C++ combine ...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/users/pierre-vh/gicomb-combine-operator
  Home:   https://github.com/llvm/llvm-project
  Commit: 0609a3d10e8a230a9a803f9083451fe8feed9821
      https://github.com/llvm/llvm-project/commit/0609a3d10e8a230a9a803f9083451fe8feed9821
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/docs/GlobalISel/MIRPatterns.rst
    M llvm/include/llvm/Target/GlobalISel/Combine.td
    M llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td
    M llvm/test/TableGen/GlobalISelCombinerEmitter/pattern-errors.td
    M llvm/test/TableGen/GlobalISelCombinerEmitter/pattern-parsing.td
    M llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp

  Log Message:
  -----------
  [GlobalISel] Add `combine` action for C++ combine rules

Adds a `combine` action (DAG operator) which allows for easy definition of
combine rule that only match one or more instructions, and defer all remaining
match/apply logic to C++ code.

This avoids the need for split match/apply function in such cases. One function
can do the trick as long as it returns `true` if it changed any code.

This is implemented as syntactic sugar over match/apply. The combine rule is
just a match pattern BUT every C++ pattern inside is treated as an "apply" function.
This makes it fit seamlessly with the current backend.

Fixes #92410


  Commit: 2dbed9a2f960aa587520e3cac40f59fcbb6684d6
      https://github.com/llvm/llvm-project/commit/2dbed9a2f960aa587520e3cac40f59fcbb6684d6
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/test/TableGen/GlobalISelCombinerEmitter/pattern-errors.td
    M llvm/utils/TableGen/GlobalISelCombinerEmitter.cpp

  Log Message:
  -----------
  lowercase error message


Compare: https://github.com/llvm/llvm-project/compare/8364585d6b77...2dbed9a2f960

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications