[all-commits] [llvm/llvm-project] 9f4972: [AMDGPU][SplitModule] Do not create empty modules

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/users/pierre-vh/amdsplitmodule-skip-parts
  Home:   https://github.com/llvm/llvm-project
  Commit: 9f49720edab27dc1d08e00b1681e72a07af0fe92
      https://github.com/llvm/llvm-project/commit/9f49720edab27dc1d08e00b1681e72a07af0fe92
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/include/llvm/Target/TargetMachine.h
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
    M llvm/test/tools/llvm-split/AMDGPU/address-taken-externalize-with-call.ll
    M llvm/test/tools/llvm-split/AMDGPU/large-kernels-merging-weak_odr.ll
    M llvm/test/tools/llvm-split/AMDGPU/large-kernels-merging.ll
    A llvm/test/tools/llvm-split/AMDGPU/preserve-globals.ll

  Log Message:
  -----------
  [AMDGPU][SplitModule] Do not create empty modules

Skip creating a module if no function is going to be imported.
Also includes a change so that if the first partition is empty (which can happen),
we import global with non-local linkage into the first non-empty partition, instead
of P0 all the time.

I thought we'd need to change users of the SplitModule callback so they can deal with less modules
than the number requested, but no. We already return only 1 module in some cases and
it seems to be handled just fine.


  Commit: c58d21d816a31a03bdc20c91ffe62f14a01121c0
      https://github.com/llvm/llvm-project/commit/c58d21d816a31a03bdc20c91ffe62f14a01121c0
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp

  Log Message:
  -----------
  comments


  Commit: 0f680c80daa1c08b33b2e66af58e6bbdbc3d9a62
      https://github.com/llvm/llvm-project/commit/0f680c80daa1c08b33b2e66af58e6bbdbc3d9a62
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2025-04-22 (Tue, 22 Apr 2025)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp

  Log Message:
  -----------
  comments


Compare: https://github.com/llvm/llvm-project/compare/c1a06b277251...0f680c80daa1

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications