[all-commits] [llvm/llvm-project] 6423c9: [mlir][LLVM][NFC] Avoid rollback in FuncOp --> LLV...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6423c901fd5a5a8370a5326c5fbe16eb5a837374
      https://github.com/llvm/llvm-project/commit/6423c901fd5a5a8370a5326c5fbe16eb5a837374
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-04-21 (Mon, 21 Apr 2025)

  Changed paths:
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp

  Log Message:
  -----------
  [mlir][LLVM][NFC] Avoid rollback in FuncOp --> LLVM lowering (#136477)

This pattern used to create an `llvm.func` op, then check additional
requirements and return "failure". This commit moves the checks before
the creation of the replacement op, so that no rollback is necessary
when one of the checks fails.

Note: This is in preparation of the One-Shot Dialect Conversion
refactoring, which removes the rollback functionality.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications