[all-commits] [llvm/llvm-project] bb21a6: [mlir][memref] Move `AllocLikeConversion.h` helper...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bb21a6819b3fb9d689de776f7ee768030dfbacea
      https://github.com/llvm/llvm-project/commit/bb21a6819b3fb9d689de776f7ee768030dfbacea
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-04-20 (Sun, 20 Apr 2025)

  Changed paths:
    R mlir/include/mlir/Conversion/MemRefToLLVM/AllocLikeConversion.h
    R mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp
    M mlir/lib/Conversion/MemRefToLLVM/CMakeLists.txt
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

  Log Message:
  -----------
  [mlir][memref] Move `AllocLikeConversion.h` helpers into `MemRefToLLVM.cpp` (#136424)

This commit moves code around: The helper functions/classes are moved
into `MemRefToLLVM.cpp`. This simplifies the code a bit: fewer
templatized functions, fewer function calls, fewer lines of code.

This commit also moves checks in `matchAndRewrite` to the beginning of
the functions, such that patterns bail out (`return failure()`) before
starting to modify any IR. (Apart from that, this change is NFC.) This
is in preparation of the One-Shot Dialect Conversion refactoring, which
will disallow pattern rollbacks.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications