[all-commits] [llvm/llvm-project] c0a703: [mlir][LLVM] Avoid rollback in FuncOp --> LLVM low...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/func_llvm_rollback
  Home:   https://github.com/llvm/llvm-project
  Commit: c0a7039d902f875033ab5a677674c164c5b94874
      https://github.com/llvm/llvm-project/commit/c0a7039d902f875033ab5a677674c164c5b94874
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2025-04-20 (Sun, 20 Apr 2025)

  Changed paths:
    M mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp

  Log Message:
  -----------
  [mlir][LLVM] Avoid rollback in FuncOp --> LLVM lowering

This pattern used to create an `llvm.func` op, then check additional requirements and return "failure". This commit moves the checks before the creation of the replacement op, so that no rollback is necessary when one of the checks fails.

Note: This is in preparation of the One-Shot Dialect Conversion refactoring, which removes the rollback functionality.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications