[all-commits] [llvm/llvm-project] c47042: [mlir][SPRIV][NFC] Avoid rollback in `TypeCastingO...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c47042c5b3f5e87761715a9277712721512cd48d
      https://github.com/llvm/llvm-project/commit/c47042c5b3f5e87761715a9277712721512cd48d
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-04-19 (Sat, 19 Apr 2025)

  Changed paths:
    M mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp

  Log Message:
  -----------
  [mlir][SPRIV][NFC] Avoid rollback in `TypeCastingOpPattern` (#136284)

This pattern used to create an op and then attached the converted
rounding mode attribute. When the latter failed, the pattern aborted and
a rollback was triggered.

This commit inverses the logic: the converted rounding mode is computed
first, so that no changes have to be rolled back.

Note: This is in preparation of the One-Shot Dialect Conversion
refactoring.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications