[all-commits] [llvm/llvm-project] fc1e31: [mlir][memref] Fix rollback in test case during `c...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc1e311966c59368e63b834a42523ce104711a94
      https://github.com/llvm/llvm-project/commit/fc1e311966c59368e63b834a42523ce104711a94
  Author: Matthias Springer <me at m-sp.org>
  Date:   2025-04-18 (Fri, 18 Apr 2025)

  Changed paths:
    M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir

  Log Message:
  -----------
  [mlir][memref] Fix rollback in test case during `convert-to-llvm` (#135958)

This commit is in preparation of the One-Shot Dialect Conversion
refactoring, which removes the rollback from the dialect conversion
framework.

`GenericAtomicRMWOpLowering` (`generic_atomic_rmw`) triggered a rollback
in two test cases. The lowering pattern adds additional basic blocks to
the enclosing operation, which used to be a `func.func` (now
`llvm.func`). Adding a basic block triggers legalization of the op that
owns the basic block. This fails when running
`--convert-to-llvm="filter-dialects=memref"` because no lowering
patterns for the `func` dialect were populated and only `llvm` ops are
considered "legal" by the `convert-to-llvm` pass, causing a rollback of
the entire `GenericAtomicRMWOpLowering` pattern.

Also add extra `CHECK-INTERFACE` to make sure that all test cases are
correctly lowered with `--convert-to-llvm="filter-dialects=memref"`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications