[all-commits] [llvm/llvm-project] 3b82d8: [mlir][SPRIV][NFC] Avoid rollback in `TypeCastingO...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/no_rollback_spirv_cast
  Home:   https://github.com/llvm/llvm-project
  Commit: 3b82d8e9998ce43a2b5fdeff4e1c1d3a12ba7ba5
      https://github.com/llvm/llvm-project/commit/3b82d8e9998ce43a2b5fdeff4e1c1d3a12ba7ba5
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2025-04-18 (Fri, 18 Apr 2025)

  Changed paths:
    M mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp

  Log Message:
  -----------
  [mlir][SPRIV][NFC] Avoid rollback in `TypeCastingOpPattern`

This pattern used to create an op and then attached the converted rounding mode attribute. When the latter failed, a rollback was triggered.

This commit inverses the logic: the converted rounding mode is computed first, so that no changes have to be rolled back.

Note: This is in preparation of the One-Shot Dialect Conversion refactoring.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications