[all-commits] [llvm/llvm-project] ca9ec7: [ARM, AArch64] Fix passing of structures with alig...

[Harald van Dijk via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ca9ec7dfc3a5ebad9e5c25b30511b2ed73287f61
      https://github.com/llvm/llvm-project/commit/ca9ec7dfc3a5ebad9e5c25b30511b2ed73287f61
  Author: Harald van Dijk <harald.vandijk at codeplay.com>
  Date:   2025-04-18 (Fri, 18 Apr 2025)

  Changed paths:
    M clang/include/clang/AST/RecordLayout.h
    M clang/lib/AST/RecordLayoutBuilder.cpp
    M clang/test/CodeGen/AArch64/args.cpp
    M clang/test/CodeGen/aapcs64-align.cpp
    M clang/test/CodeGen/arm-vfp16-arguments2.cpp

  Log Message:
  -----------
  [ARM, AArch64] Fix passing of structures with aligned base classes (#135564)

RecordLayout::UnadjustedAlignment was documented as "Maximum of the
alignments of the record members in characters", but
RecordLayout::getUnadjustedAlignment(), which just returns
UnadjustedAlignment, was documented as getting "the record alignment in
characters, before alignment adjustement." These are not the same thing:
the former excludes alignment of base classes, the latter takes it into
account. ItaniumRecordLayoutBuilder::LayoutBase was setting it according
to the former, but the AAPCS calling convention handling, currently the
only user, relies on it being set according to the latter.

Fixes #135551.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications